[Bug 757925] bufferpool config: function to remove an option in the config

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 11 06:46:08 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=757925

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315224:
 --> (https://bugzilla.gnome.org/review?bug=757925&attachment=315224)

::: gst/gstbufferpool.c
@@ +892,3 @@
+ * not contain the specified option, @config is not modified.
+ *
+ * The supported options by @pool can be retrieved with
gst_buffer_pool_get_options().

Since: 1.8

@@ +901,3 @@
+  guint i, len;
+
+  g_return_if_fail (config != NULL);

Maybe should also get a g_return_if_fail() to check if the structure is
writable, but then we also don't do that elsewhere.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list