[Bug 758041] tcpserversrc: blocksize property of basesrc has no effect

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758041

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315386|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315386:
 --> (https://bugzilla.gnome.org/review?bug=758041&attachment=315386)

::: gst/tcp/gsttcpserversrc.c
@@ +242,3 @@
   if (avail > 0) {
+    g_object_get (src, "blocksize", &blocksize, NULL);
+    read = MIN (avail, blocksize);

Use gst_base_src_get_blocksize() here instead. blocksize might also be -1 or 0,
need to check for that.

Not sure if this is the best idea though, if already more than blocksize is
available on the socket in the receive buffer, there is not really a
disadvantage of taking it all at once, or is there?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.