[Bug 758078] plugin: Dependency hash does not work 32 or more files

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 13 13:04:23 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=758078

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
I'm coming from far, but I have the impression that this shift was meant to
make the addition non-commutative. So if the orders of files changes, you'll
get a different hash. If this is exact, the implementation is incorrect, you
need to rotate the hash, that means saving the last bit, shifting, and adding
back that bit.

Though, when I look at what it is doing, what we really care about is that
hash, the order in which files are listed shall not matter. For this reason, I
suggest to simply drop that shifting.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list