[Bug 758215] New: gstaudiobasesink should it return ERROR for clips with audio corrupt track.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758215

            Bug ID: 758215
           Summary: gstaudiobasesink should it return ERROR for clips with
                    audio corrupt track.
    Classification: Platform
           Product: GStreamer
           Version: 1.6.0
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: lyon.wang at freescale.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

When I'm playing to playing clips with audio corrupt track.
and it will just quit and report error in gst_audio_base_sink_wait_event()
that  "sink not negotiated before EOS event"

while on GST1.4.5, these clips doesn't meet this issue.
I checked gst_audio_base_sink_wait_event()
there is a commit for this on GST1.6:

commit 1df69786c3b0fb5381616c5ff048002519e28f94
Author: Jan Schmidt <jan at centricular.com>
Date:   Wed Jan 28 22:42:17 2015 +1100

    audiobasesink: Make sure the ringbuffer is started before waiting

    Don't call the basesink wait_event implementation until we're sure
    the ringbuffer is running, because it might wait on a non-running
    clock.

But for those clips with corrupt audio track, there might be no output from
audio decoder, and thus the audio track have no chance to negotiate.

Do it really need return GST_ELEMENT_ERROR() and quit playing for those clips
with audio corrupt track?

Similar as https://bugzilla.gnome.org/show_bug.cgi?id=741542 audio/video
decoder error, we've tried not to return GST_ELEMENT_ERROR(), and keep other
track to play normally. 

could we just print warning(error) instead  as what we do for audiodecoder.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.