[Bug 757961] baseparse: do not overwrite header buffer timestamps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757961

Nicola <lists at svrinformatica.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lists at svrinformatica.it

--- Comment #12 from Nicola <lists at svrinformatica.it> ---
this patch seems to break my app, please take a look to these logs

0:00:00.157222961 15683      0x277a400 LOG                baseparse
gstbaseparse.c:1994:gst_base_parse_prepare_frame:<video_muxer_parser> preparing
frame at offset 18446744073709551615 (0xffffffffffffffff) of size 16981
0:00:00.157255415 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:789:gst_base_parse_update_frame:<video_muxer_parser> marking
DISCONT
0:00:00.157276147 15683      0x277a400 LOG                baseparse
gstbaseparse.c:794:gst_base_parse_update_frame:<video_muxer_parser> marking as
new frame
0:00:00.157417421 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:3710:gst_base_parse_set_frame_rate:<video_muxer_parser> invalid
fps (0/1), ignoring parameters
0:00:00.157452776 15683      0x277a400 LOG                baseparse
gstbaseparse.c:3732:gst_base_parse_set_frame_rate:<video_muxer_parser> set fps:
0/0 => duration: 18446744073709 ms
0:00:00.157476917 15683      0x277a400 LOG                baseparse
gstbaseparse.c:3736:gst_base_parse_set_frame_rate:<video_muxer_parser> set lead
in: 0 frames = 0 ms, lead out: 0 frames = 0 ms
0:00:00.157585896 15683      0x277a400 LOG                baseparse
gstbaseparse.c:2505:gst_base_parse_finish_frame:<video_muxer_parser> finished
frame at offset 0, flushing size 16981
0:00:00.157649401 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:1871:gst_base_parse_check_seekability:<video_muxer_parser>
seeking query failed
0:00:00.157675616 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:1912:gst_base_parse_check_seekability:<video_muxer_parser>
seekable: 0 (18446744073709551615 - 18446744073709551615)
0:00:00.157706211 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:1916:gst_base_parse_check_seekability:<video_muxer_parser>
idx_interval: 0ms
0:00:00.157748558 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:1935:gst_base_parse_check_upstream:<video_muxer_parser>
upstream_has_duration: 0
0:00:00.157778256 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:2211:gst_base_parse_handle_and_push_frame:<video_muxer_parser>
no next fallback timestamp
0:00:00.157803564 15683      0x277a400 LOG                baseparse
gstbaseparse.c:2270:gst_base_parse_push_frame:<video_muxer_parser> processing
buffer of size 16981 with dts 99:99:99.999999999, pts 99:99:99.999999999,
duration 99:99:99.999999999
0:00:00.157861822 15683      0x277a400 DEBUG              baseparse
gstbaseparse.c:1958:gst_base_parse_check_media:<video_muxer_parser> media is
video: 1

as you can see there is a frame of size 16981 (first keyframe) that enter with
a valid pts and is pushed with invalid timestamp. In my app this frame is
passed to matroskamux that drop it since has no pts/dts set and so the
resulting video miss the first keyframe.

I'll do some more investigations later today and try to reproduce with
gst-launch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.