[Bug 742643] isomp4: Add support for Opus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742643

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315759|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315759:
 --> (https://bugzilla.gnome.org/review?bug=742643&attachment=315759)

::: gst/isomp4/gstqtmux.c
@@ +3685,3 @@
+
+    ext_atom = build_opus_extension (rate, channels, mapping_family,
+        stream_count, coupled_count, channel_mapping, 0, 0);

These two zeroes here are not good :) The first zero would ideally be
calculated from the GstAudioClippingMeta of the first buffers, the second we
might want to add to the caps. Alternatively you can require a OpusHead
streamheader in the caps (like oggmux/matroskamux) and read the two values from
there. Transmuxing from e.g. RTP would require using opusparse then.

::: gst/isomp4/gstqtmuxmap.c
@@ +136,3 @@
+  "audio/x-opus, " \
+  "channels = (int) [1, 8], " \
+  "channel-mapping-family = (int) {0, 1};"

In theory we should also support other families and more channels

-- 
You are receiving this mail because:
You are the QA Contact for the bug.