[Bug 742643] isomp4: Add support for Opus

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742643

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315775|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315775:
 --> (https://bugzilla.gnome.org/review?bug=742643&attachment=315775)

Main question remaining now is if anything special with the timestamps is
needed like with Matroska, because of the pre-skip and padding for the last
frame. Our timestamps will start at 0 and duration of the first frame will be
shorter, and then the last frame will also have a shorter duration. For
Matroska for example, the container wants timestamps/durations that include the
pre-skip and padding.

::: gst/isomp4/gstqtmux.c
@@ +3686,3 @@
+        !GST_VALUE_HOLDS_ARRAY (streamheader) ||
+        gst_value_array_get_size (streamheader) == 0) {
+      GST_ERROR ("no streamheader field in caps %" GST_PTR_FORMAT, caps);

GST_ERROR_OBJECT()

@@ +3687,3 @@
+        gst_value_array_get_size (streamheader) == 0) {
+      GST_ERROR ("no streamheader field in caps %" GST_PTR_FORMAT, caps);
+      goto refuse_caps;

We could also just make this a warning and assume that the two values are 0 and
just use the caps instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.