[Bug 758258] matroska: Missing support for prores video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758258

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315805|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 315805:
 --> (https://bugzilla.gnome.org/review?bug=758258&attachment=315805)

::: gst/matroska/matroska-demux.c
@@ +2995,3 @@
+  gst_buffer_unmap (newbuf, &map);
+  gst_buffer_append (newbuf, *buf);
+  *buf = newbuf;

*buf = gst_buffer_append (newbuf, *buf);

append() returns a new buffer and takes ownership of both its arguments

@@ +5268,3 @@
+
+    GST_LOG ("Prores video, codec fourcc %" GST_FOURCC_FORMAT,
+        GST_FOURCC_ARGS (fourcc));

Should we put the fourcc into the caps?

@@ +5271,3 @@
+
+    caps = gst_caps_new_empty_simple ("video/x-prores");
+    *codec_name = g_strdup_printf ("Apple ProRes");

This stuff should everywhere use pbutils :) But at a later time

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.