[Bug 758258] matroska: Missing support for prores video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758258

--- Comment #6 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 315805 [details] [review]:
> 
> ::: gst/matroska/matroska-demux.c
> @@ +2995,3 @@
> +  gst_buffer_unmap (newbuf, &map);
> +  gst_buffer_append (newbuf, *buf);
> +  *buf = newbuf;
> 
> *buf = gst_buffer_append (newbuf, *buf);
> 
> append() returns a new buffer and takes ownership of both its arguments

Thanks! Fixed.

> @@ +5268,3 @@
> +
> +    GST_LOG ("Prores video, codec fourcc %" GST_FOURCC_FORMAT,
> +        GST_FOURCC_ARGS (fourcc));
> 
> Should we put the fourcc into the caps?

Looking at qtmux, it seems the fourcc should be mapped to one of 4
'variant=(string)..." values. That should allow remuxing, and gives
matroska-mux the info it would need to implement handling too.

> @@ +5271,3 @@
> +
> +    caps = gst_caps_new_empty_simple ("video/x-prores");
> +    *codec_name = g_strdup_printf ("Apple ProRes");
> 
> This stuff should everywhere use pbutils :) But at a later time

Is that just gst_pb_utils_get_codec_description() ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.