[Bug 709826] mpegtsmux: performance issue

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=709826

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #315831|none                        |needs-work
             status|                            |

--- Comment #17 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 315831:
 --> (https://bugzilla.gnome.org/review?bug=709826&attachment=315831)

::: gst/mpegtsmux/mpegtsmux.c
@@ +372,3 @@
   GstBuffer *buf;
   GSList *walk;
+  GstStructure *poolConfig;

Coding style: use pool_config (or just config as everywhere else).

@@ +421,3 @@
+  poolConfig = gst_buffer_pool_get_config (mux->pool);
+  gst_buffer_pool_set_active (mux->pool, FALSE);
+  gst_buffer_pool_config_set_params (poolConfig, NULL, 188, 100, 0);

That is a bit of a waste of time. You free to reallocate the exact same thing.
Imho, I'd let the pool grow by itself, and use a start size of about a standard
mtu.

You should probably deactivate when going to READY state, and activate when
going to PAUSED state instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.