[Bug 742446] sbcparse: Frame coalescing broken for joint stereo

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 19 02:36:03 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=742446

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the patch, just one quick question: your new formula doesn't align
with the formula given in the spec (12.9 Calculation of Bit Rate and Frame
Length).

I would like to understand why this is the case, and I think it would be good
to keep the code aligned with that formula.

Perhaps we should be doing the calculation in floating point and simply round
up to the nearest byte, I guess we're truncating/rounding down now when there
are extra bits, and that's why you're just adding another byte here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list