[Bug 755918] decodebin: Fix assertion errors when caps is not fixed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755918

Vineeth <vineeth.tm at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312466|reviewed                    |none
             status|                            |
 Attachment #312466|0                           |1
        is obsolete|                            |

--- Comment #7 from Vineeth <vineeth.tm at samsung.com> ---
Created attachment 316073
  --> https://bugzilla.gnome.org/attachment.cgi?id=316073&action=edit
fix get_topology logic to remove possible assertion errors

gst_decode_chain_get_topology will be called when the decode chain is being
exposed. At this time the chain caps will be fixed. So there is no need to
check if the caps is fixed or not.
And removing duplicate gst_pad_get_current_caps function, as the same will be
already done in get_pad_caps. And if get_pad_caps returns NULL(which is
unlikely), just return the incomplete caps. Because passing NULL caps to 
   gst_structure_id_set (u, topology_caps, GST_TYPE_CAPS, caps, NULL);
will cause assertion errors.
And in case endchain doesnt have any valid caps(which is again unlikely), then
get_topology returns NULL, which will cause assertion errors when passed to
gst_message_new_element. Hence adding a precautionary check.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.