[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316103|none                        |reviewed
             status|                            |

--- Comment #50 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316103:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316103)

Looks ok

::: gst-libs/gst/gl/gstglmemory.c
@@ +139,3 @@
+  switch (type) {
+    case GST_VIDEO_GL_TEXTURE_TYPE_LUMINANCE:
+      return "LUMINANCE";

I would prefer "luminance" and "luminance-alpha" (i.e. lower case for words)
here to match the texture-target definition.  Acronyms can have capital
letters.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.