[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316106|none                        |reviewed
             status|                            |

--- Comment #52 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316106:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316106)

Looks fine.

::: configure.ac
@@ +812,3 @@
+HAVE_DRM_FOURCC_HEADER=no
+AC_CHECK_HEADER(libdrm/drm_fourcc.h,
+  HAVE_DRM_FOURCC_HEADER=yes, )

nitpick. Indentation (4 spaces)

@@ +816,3 @@
+HAVE_GST_ALLOCATORS=no
+PKG_CHECK_MODULES(GST_ALLOCATORS, gstreamer-allocators-1.0,
+  HAVE_GST_ALLOCATORS=yes, )

nitpick. Indentation. (4 spaces)

@@ +821,3 @@
+        "x$HAVE_GST_ALLOCATORS" = "xyes" -a \
+        "x$HAVE_EGL" = "xyes"; then
+          AC_DEFINE(GST_GL_HAVE_DMABUF, [1] , [DMABUF available for gl
plugins])

nitpick. Indentation. (2 spaces)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.