[Bug 711155] wayland: add wl_drm support to wayland sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=711155

--- Comment #67 from George Kiagiadakis <george.kiagiadakis at collabora.com> ---
(In reply to Fabien Dessenne from comment #66)
> I have reworked the previous "linux_dmabuf protocol support" patch that was
> attached by Benjamin Gaignard.
> The major change from the previous version is the removal of the dmabuf
> buffer pool (that was DRM dumb buffer based).
> The sink handles both SHM and dmabuf buffers
> 
> There are still some issues to fix, in the base classes of decoder and
> transform to have everyhting working fine in both shm/dmabuf modes, but I
> think that this is a good starting point
> 
> Fabien

I see a collision here as we are both working on the same thing apparently.

A few notes on your patch:
* It still depends on libdrm (I know we have to use drm_fourcc.h, but it
doesn't justify the dependency for me, as it's just a couple of constants. I
prefer copying them over).
* It's not based on master (and I can tell it does not apply cleanly on master)
* GST_VIDEO_FORMATS is confusing as a name, since there is another constant
like that in the gstvideo library
* Using gst_wl_display_rountrip() is bad. At that time that you call it, the
event queue is polled by another thread in wldisplay.c, so doing a sync
roundtrip in another thread while the event loop thread is running in parallel
is prone to cause races.

Finally, I see that you are now using the "memory:dmabuf" caps feature. I
thought that you were trying to avoid that. Do you have reconsidered your
proposal, or do you agree/disagree with my proposal in the comments above? It
would be useful to discuss a bit more about it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.