[Bug 753751] Dashdemux: returned seekable range for live streams is not usable

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753751

--- Comment #45 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 312366:
 --> (https://bugzilla.gnome.org/review?bug=753751&attachment=312366)

::: ext/dash/gstdashdemux.c
@@ +315,3 @@
+  GstClockTime seg_duration;
+
+  /* TODO: use gst_mpd_client_get_segment_duration() to get real segment
duration */

Be careful that gst_mpd_client_get_segment_duration uses base->duration without
testing that it actually exists. For example, if segment timeline is being
used, duration will not be set.

@@ +316,3 @@
+
+  /* TODO: use gst_mpd_client_get_segment_duration() to get real segment
duration */
+  seg_duration = self->client->mpd_node->maxSegmentDuration * GST_MSECOND;

Currently maxSegmentDuration could be undefined (set to -1). You need to test
for that.

The standard says "If not present, then the maximum Segment duration shall be
the maximum duration of any Segment documented in this MPD". Ideally, the code
should update maxSegmentDuration every time a segment duration is
parsed/computed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.