[Bug 758384] dashdemux: tests: refactor into adaptive_engine components

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758384

--- Comment #15 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Thiago Sousa Santos from comment #9)
> Review of attachment 315946 [details] [review]:
> 
> ::: tests/check/elements/adaptive_demux_common.c
> @@ +171,3 @@
> +  if (testOutputStreamData->expected_data) {
> +    gsize size = gst_buffer_get_size (buffer);
> +    fail_unless ((streamOffset + size) <=
> testOutputStreamData->expected_size);
> 
> Not sure I understand this.
> 
> What happens if you would seek to byte=100 and was only expecting to receive
> 10 bytes after it.
> 
> What would expected_size contain in this case and how streamOffset + size
> can be smaller than the expected size?

This fail_unless is wrong and should be removed.
When I added it I thought expected_size will be the size of expected_data
(which is correct for many situations, but not all of them) and I wanted to
protect the memcp.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.