[Bug 758703] v4l2src: gst_v4l2_set_attribute warning messages cause infinite loop with .dot dump

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 26 05:48:24 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=758703

--- Comment #4 from patcherwork at gmail.com ---
The reason those four controls cause the problem is because of the
gst_v4l2_object_set_property_helper function in v4l2object, at line 578:

    case PROP_BRIGHTNESS:
    case PROP_CONTRAST:
    case PROP_SATURATION:
    case PROP_HUE:
    {
      gint cid = gst_v4l2_object_prop_to_cid (prop_id);

      if (cid != -1) {
        if (GST_V4L2_IS_OPEN (v4l2object)) {
          gst_v4l2_set_attribute (v4l2object, cid, g_value_get_int (value));
        }
      }
      return TRUE;
    }

That calls set attribute that does no sanitization for the call. The
alternative could be to implement a check here, but you would need to have a
list of the available controls and cross correlate it with what you're calling.
But that might be overkill.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list