[Bug 758699] Assume unknown OMX color formats are similar to YUV420

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758699

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #4)
> (In reply to Mathias Hasselmann (IRC: tbf) from comment #3)
> > (In reply to Nicolas Dufresne (stormer) from comment #2)
> > > That seems a very crash prone idea for the case where it's not.
> > 
> > Yes, still we have to find a way to deal with all the undefined color
> > formats reported by all this real hardware out in the wild. Actually could
> > not find a single Android device that had a H.264 hardware decoder reporting
> > any supported color format.
> 
> Yes, that way already exist, it's called texture rendering. We are already
> working on this.

And that is already finished now in gst-plugins-bad GIT with Matthew's latest
changes. Only needs some wider testing :)

> > Well, guess I should add all the well known formats to the switch statement.
> > Any maybe we can have some sanity checks, that verify if the buffer has
> > exactly the expected size, as indicated by the chosen color format.
> 
> For the mappable memory, the appropriate thing to do is report all the
> values that are found and map them. There is additional meta-data for most
> of these I420 and NV12 (I believe it's half NV12 and half I420 unlike what
> you mention). The size and the stride of I420 and NV12 is exactly the same.

Yes I also dislike this idea. And if anything we should probably use NV12
instead of I420, NV12 seems to be slightly more common.
But in general this is not a good idea, instead we should report an error
message and let the user report a bug directly. Otherwise users will just see
that "GStreamer does not work" instead of getting the information that it's
just Android that is providing completely useless APIs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.