[Bug 757892] rtph264pay: add config-interval option to send PPS/SPS before every key frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757892

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.7.1
            Summary|rtph264pay: send PPS/SPS    |rtph264pay: add
                   |before every key frame      |config-interval option to
                   |                            |send PPS/SPS before every
                   |                            |key frame

--- Comment #20 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Adding additional choices usually makes it harder to get stuff merged ;)

I was going to squash it like in Anton's original patch, but I've now pushed
the two patches as suggested by Sebastian, it's nicer to do it in two separate
steps and in that order (to not remove something again just added by the
previous patch).

commit 453a618a9dc0ee6b35532f8b6c1d526300e17c54
Author: Anton Bondarenko <antonbo at axis.com>
Date:   Fri Nov 27 09:27:29 2015 +0100

    rtph264pay: add "send SPS/PPS with every key frame" mode

    It's not enough to have timeout or event based SPS/PPS information sent
    in RTP packets. There are some scenarios when key frames may appear
    more frequently than once a second, in which case the minimum timeout
    for "config-interval" of 1 second for sending SPS/PPS is not sufficient.
    It might also be desirable in general to make sure the SPS/PPS is
    available with every keyframe (packet loss aside), so receivers can
    actually pick up decoding immediately from the first keyframe if
    SPS/PPS is not signaled out of band.

    This patch adds the possibility to send SPS/PPS with every key frame. This
    mode can be enabled by setting "config-interval" property to -1. In this
    case the payloader will add SPS and PPS before every key (IDR) frame.

    https://bugzilla.gnome.org/show_bug.cgi?id=757892

commit 3026d1094b0041c9d43279cdb6a441391c6e6170
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Fri Nov 27 09:03:51 2015 +0100

    rtph264pay: change config-interval property type from uint to int

    This way we can use -1 as special value, which is nicer than MAXUINT.
    This is backwards compatible even with the GValue API, as shown by
    a unit test.

    https://bugzilla.gnome.org/show_bug.cgi?id=757892

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.