[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

--- Comment #63 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Matthew Waters from comment #55)
> Review of attachment 316108 [details] [review]:
> 
> Some comments
> 
> ::: gst-libs/gst/gl/gstglupload.c
> @@ +524,3 @@
> +GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE_WITH_FEATURES
> +    ("memory:" GST_ALLOCATOR_DMABUF,
> +        "{ ABGR, ARGB, BGRA, BGRx, RGB16, RGBA, RGBx, xBGR, xRGB }"));
> 
> The example pipeline in the blurb won't work with this template.  There are
> no YUV formats here so format=NV12 is using the raw uploader which means
> nothing has changed.

In fact, it's using it, though not with memory:DMABuf caps feature. How to use
that new caps feature isn't well defined, and is not essential for libgstgl
(because we have fallbacks for everything). So let's remove that for now,
George is also working on improving how we will use that caps feature, we can
then implement seperatly and consistently.

> 
> @@ +592,3 @@
> +      gst_buffer_ref (buffer);
> +      gst_mini_object_set_qdata ((GstMiniObject *) image->outbuf,
> +          quark, buffer, (GDestroyNotify) gst_buffer_unref);
> 
> Perhaps the GstParentBufferMeta would work better than setting some qdata.

It's a good idea. Currently it make no difference because outbuf is not pooled,
but if we fix this "issue", it will break.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.