[Bug 743345] glupload: Add support for dmabuf

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743345

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #316414|none                        |needs-work
             status|                            |

--- Comment #68 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 316414:
 --> (https://bugzilla.gnome.org/review?bug=743345&attachment=316414)

Some comments

::: gst-libs/gst/gl/egl/gsteglimagememory.c
@@ +438,3 @@
+
+  gint n_mem = gst_buffer_n_memory (in_buffer);
+  GstVideoMeta *meta = gst_buffer_get_video_meta (in_buffer);

The input buffer may not have GstVideoMeta which is crash prone.

@@ +472,3 @@
+
+        if (!plane1 || !plane2)
+          return NULL;

memory leak on failure of plane1 or plane2.

@@ +496,3 @@
+
+        if (!plane1 || !plane2 || !plane3)
+          return NULL;

memory leak on failure.

::: gst-libs/gst/gl/egl/gsteglimagememory.h
@@ +65,3 @@
     GstVideoGLTextureOrientation orientation);

+#if GST_GL_HAVE_DMABUF

This does not interact will with the build addition patch and other libraries
attempting to use libgstgl's dmabuf.  The build patch only does a AC_DEFINE
which places it in config.h to which any library using libgstgl would need to
replicate.  The GST_GL_HAVE_DMABUF should go into gstglconfig.h so that
libraries always get the correct API.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.