[Bug 752336] dashdemux: duration field could overflow

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752336

--- Comment #29 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 312499:
 --> (https://bugzilla.gnome.org/review?bug=752336&attachment=312499)

I think it looks great. I don't think we can overflow the duration any more.
Make sure you mark the initial 3 patches as obsolete.

::: ext/dash/gstmpdparser.c
@@ +844,3 @@
+  if (*v > G_MAXUINT64 / mul)
+    return FALSE;
+  *v *= mul;

I suggest you do this in a local variable. A function should not touch output
parameters if returning error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.