[Bug 752367] dashdemux: adaptation set language could be better detected

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Oct 2 02:02:51 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=752367

A Ashley <bugzilla at ashley-family.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310976|none                        |needs-work
             status|                            |

--- Comment #4 from A Ashley <bugzilla at ashley-family.net> ---
Review of attachment 310976:
 --> (https://bugzilla.gnome.org/review?bug=752367&attachment=310976)

::: ext/dash/gstdashdemux.c
@@ +542,3 @@
+        for (GList * it = g_list_first (adp_set->ContentComponents);
+            it != g_list_last (adp_set->ContentComponents);
+            it = g_list_next (it)) {

Doesn't that skip the last item in the list?

Should it be:
for (GList * it = g_list_first (adp_set->ContentComponents);
        it;  it = g_list_next (it)) {

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list