[Bug 755732] rtmpsrc: Slow teardown of connection when pipeline is interrupted

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755732

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312302|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312302:
 --> (https://bugzilla.gnome.org/review?bug=755732&attachment=312302)

::: ext/rtmp/gstrtmpsrc.c
@@ +343,3 @@
+     * to timeout on its recv call. */
+    poll_state = gst_poll_wait (src->poll, GST_CLOCK_TIME_NONE);
+    if ((poll_state == -1) && (errno == EBUSY)) {

The extra parenthesis are not needed here :)

@@ +661,2 @@
   if (src->rtmp) {
+    gst_poll_set_flushing (src->poll, FALSE);

Shouldn't this be flushing in stop(), and non-flushing in start()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.