[Bug 755867] playsink: fix leak of audio sink

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755867

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312413|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312413:
 --> (https://bugzilla.gnome.org/review?bug=755867&attachment=312413)

::: gst/playback/gstplaysink.c
@@ +2768,3 @@
   if (elem) {
     chain->volume = elem;
+    gst_object_unref (elem);

Why is this correct? And there's the same code in line 2971 :)

I wonder why we don't keep another reference around of the chain->volume
thing... and unref it later. That would seem more consistent.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.