[Bug 755918] decodebin: Fix assertion errors when caps is not fixed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755918

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312466|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312466:
 --> (https://bugzilla.gnome.org/review?bug=755918&attachment=312466)

::: gst/playback/gstdecodebin2.c
@@ +4449,3 @@
       gst_caps_unref (caps);
+      gst_structure_free (u);
+      return NULL;

Seems a bit extreme to directly return NULL here. What about returning
incomplete information instead?

Also how can you even get unfixed caps here?

@@ +4468,3 @@
   s = gst_decode_chain_get_topology (dbin->decode_chain);

+  if (s) {

When does it return NULL? Should probably cause a GST_WARNING_OBJECT()
somewhere.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.