[Bug 756049] New: vp8dec: few conditions that will rarely be true are missing the compiler hints for likely branch prediction

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756049

            Bug ID: 756049
           Summary: vp8dec: few conditions that will rarely be true are
                    missing the compiler hints for likely branch
                    prediction
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: vikram.fugro at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Can be optimized with G_UNLIKELY()/LIKELY() macros.

517   if ===>(!dec->decoder_inited)<==== {
518     ret = open_codec (dec, frame);
519     if (ret == GST_FLOW_CUSTOM_SUCCESS_1)
520       return GST_FLOW_OK;
521     else if (ret != GST_FLOW_OK)
522       return ret;
523   }

534   if ===>(!gst_buffer_map (frame->input_buffer, &minfo, GST_MAP_READ))<===
{
535     GST_ERROR_OBJECT (dec, "Failed to map input buffer");
536     return GST_FLOW_ERROR;
537   }

544   if ===>(status)<=== {
545     GST_VIDEO_DECODER_ERROR (decoder, 1, LIBRARY, ENCODE,
546         ("Failed to decode frame"), ("%s", gst_vpx_error_name (status)),
ret);
547     return ret;
548   }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.