[Bug 755999] gstharness: add gst_harness_set_single_segment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755999

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312589|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312589:
 --> (https://bugzilla.gnome.org/review?bug=755999&attachment=312589)

::: libs/gst/check/gstharness.c
@@ +259,1 @@
     case GST_EVENT_SEGMENT:

What about resetting the segment on FLUSH_STOP?

@@ +265,3 @@
+        if (clock) {
+          priv->running_time_offset = gst_clock_get_time (clock) -
+              gst_element_get_base_time (h->element);

Why are you taking the clock here as an offset? That doesn't really make much
sense IMHO, it should just output the current running time as is without
offsetting. Is identity doing the same?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.