[Bug 755971] queue2: may overflow unsigned integer arithmetic

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755971

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312551|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 312551:
 --> (https://bugzilla.gnome.org/review?bug=755971&attachment=312551)

I think this test just need a small portability change, but seems very good
otherwise.

::: tests/check/elements/queue2.c
@@ +314,3 @@
+  for (i = 0; i < 20; i++) {
+    buffer = gst_buffer_new_and_alloc (1024);
+    GST_BUFFER_PTS (buffer) = 18446744071709551616ULL + i * (GST_SECOND / 10);
   /* 10 FPS */

Use G_GUINT64_CONSTANT() macro for portability.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.