[Bug 755326] souphttpclientsink: Fix memory leaks and segfault crash.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755326

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311814|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 311814:
 --> (https://bugzilla.gnome.org/review?bug=755326&attachment=311814)

Can you make this 3 patches?

::: ext/soup/gstsouphttpclientsink.c
@@ +255,3 @@
+      (GDestroyNotify) gst_buffer_unref);
+  g_list_free_full (souphttpsink->sent_buffers,
+      (GDestroyNotify) gst_buffer_unref);

These changes in 1)

@@ +297,3 @@
       souphttpsink->offset = 0;
+      if ((souphttpsink->location == NULL)
+          || !gst_uri_is_valid (souphttpsink->location)) {

This 2)

@@ +660,2 @@
   souphttpsink->message = soup_message_new ("PUT", souphttpsink->location);
+  if (souphttpsink->message == NULL) {

This 3)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.