[Bug 756231] mpegaudioparse: Fix buffer memory leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756231

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312890|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312890:
 --> (https://bugzilla.gnome.org/review?bug=756231&attachment=312890)

::: gst/audioparsers/gstmpegaudioparse.c
@@ +439,1 @@
       return TRUE;

goto cleanup?

@@ +678,1 @@
         return FALSE;

This looks interesting! The function returns a GstFlowReturn, not a gboolean.
Also there's a "goto cleanup" here too.

This needs some more fixup

@@ +691,1 @@
       return FALSE;

Same here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.