[Bug 756187] appsink EOS flushing behavior

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756187

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #312911|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 312911:
 --> (https://bugzilla.gnome.org/review?bug=756187&attachment=312911)

Generally looks good, thanks! Just one minor thing:

::: gst-libs/gst/app/gstappsink.c
@@ +214,3 @@
           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

+  g_object_class_install_property (gobject_class, PROP_WAIT_ON_EOS,

Add some gtk-docs here, especially the Since: 1.8 marker

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.