[Bug 742875] [API] new audiovisualizer base class

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742875

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313110|none                        |needs-work
             status|                            |

--- Comment #37 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 313110:
 --> (https://bugzilla.gnome.org/review?bug=742875&attachment=313110)

Can you squash both patches together?

::: gst/goom/Makefile.am
@@ +40,2 @@
 libgstgoom_la_CFLAGS = $(GST_PLUGINS_BASE_CFLAGS) $(GST_BASE_CFLAGS)
$(GST_CFLAGS) $(GOOM_FILTER_CFLAGS) $(ARCH_CFLAGS) $(ORC_CFLAGS)
+libgstgoom_la_LIBADD = -lgstpbutils-$(GST_API_VERSION)
$(GST_PLUGINS_BASE_LIBS) $(GST_BASE_LIBS) $(GST_LIBS) $(ORC_LIBS)

First $(GS_TPLUGINS_BASE_LIBS), then the lib

::: gst/goom2k1/Makefile.am
@@ +24,3 @@
     -DzoomFilterNew=zoomFilterNew2k1

+libgstgoom2k1_la_LIBADD = $(GST_BASE_LIBS) $(GST_PLUGINS_BASE_LIBS)
-lgstpbutils-$(GST_API_VERSION) $(GST_LIBS) $(LIBM)

First GST_PLUGINS_BASE, then GST_BASE, then GST

-- 
You are receiving this mail because:
You are the QA Contact for the bug.