[Bug 756318] souphttpclientsink: Add "retry" for request failures

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756318

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to minfrin from comment #2)

> > Why only look at the header if the property was set? Shouldn't we
> > always look at the header and respect it?
> 
> The property defaults to the current behaviour, which is to fail the
> pipeline completely. If we changes this we would break existing
> configurations.

Maybe there should be retry-delay and a retries property. The latter just
defining how many times it should retry after it fails completely.

> > Should this just be a MAX(retry, souphttpsink->retry)?
> 
> Depends on whose config should win, the client or the server. I guess the
> server config should win, I'll change this.

ACK

> > Don't use g_usleep() like that, it's not interruptible. If nothing
> > else is available for asynchronous waiting here, use a GCond and make
> > sure to unlock it when needed
> 
> Do you have an example I can look at of how to implement an interruptible
> timer safely? I searched the existing codebase of examples and only found
> the use of g_usleep().

Use a GCond and GMutex here, and g_cond_wait_until()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.