[Bug 756318] souphttpclientsink: Add "retry" for request failures

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756318

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313139|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 313139:
 --> (https://bugzilla.gnome.org/review?bug=756318&attachment=313139)

::: ext/soup/gstsouphttpclientsink.c
@@ +790,2 @@
   if (!SOUP_STATUS_IS_SUCCESSFUL (msg->status_code)) {
+    souphttpsink->failures++;

Wouldn't this only retry once here then? I think you need a loop around all
this code for the number of retries

@@ +823,3 @@
+            end_time);
+      while (res == TRUE && g_main_loop_is_running (souphttpsink->loop));
+      if (g_main_loop_is_running (souphttpsink->loop)) {

As we have a mainloop here, you could also wait on that with a
g_timeout_source_new() probably

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.