[Bug 756318] souphttpclientsink: Add "retry" for request failures

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756318

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313186|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 313186:
 --> (https://bugzilla.gnome.org/review?bug=756318&attachment=313186)

Did some minor changes to your patch, like the commit message. But:

::: ext/soup/gstsouphttpclientsink.c
@@ +180,3 @@
+  g_object_class_install_property (gobject_class, PROP_RETRIES,
+      g_param_spec_int ("retries", "Retries",
+          "Maximum number of retries, set to zero to keep trying",

What about -1 to retry forever, 0 to never retry, 1 to retry once, etc. IMHO
should be independent of retry-delay property. Setting retry-delay=0 should
just make it retry immediately.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.