[Bug 756507] multiqueue: Use buffer DTS if present, else PTS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756507

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313196|none                        |reviewed
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 313196:
 --> (https://bugzilla.gnome.org/review?bug=756507&attachment=313196)

::: plugins/elements/gstmultiqueue.c
@@ +1157,3 @@
   if (GST_IS_BUFFER (object)) {
     GstBuffer *buf = GST_BUFFER_CAST (object);
+    GstClockTime ptime = GST_BUFFER_DTS (buf);

Nitpick, but ptime sounds like presentation time, a confusing variable name
when the first thing you do it set it to DTS. Maybe, timestamp could be better
?

@@ +1166,3 @@
+      if (ptime > segment->stop)
+        ptime = segment->stop;
+      time = gst_segment_to_running_time (segment, GST_FORMAT_TIME, ptime);

As we move toward DTS, I think we need negative TS support here. I suggest
turning time into a gint64, and storing a signed version of the running time
(optained using the _full method).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.