[Bug 748316] hlsdemux: The end offset (range_end) of a segment is not calculated properly in the m3u8 parser

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Oct 14 04:13:20 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748316

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313246|needs-work                  |rejected
             status|                            |

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 313246
  --> https://bugzilla.gnome.org/attachment.cgi?id=313246
segment: Document that the segment stop position is non-inclusive

So, this patch is not good then. Following observations:
1) segment.stop is always outside the segment
2) buffer with start==stop==segment.stop is inside that segment but has zero
duration (in a byte segment, it has no bytes!)

gst_segment_clip() does it right.
gst_segment_to/from_running/stream_time() is annoying, it currently must allow
position==stop inside the segment because of 2). In 2.0 we should make it
return a signed value, and always return a value independent of segment
boundaries.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list