[Bug 756628] audioclock: Add run time type check safety

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756628

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313360|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 313360:
 --> (https://bugzilla.gnome.org/review?bug=756628&attachment=313360)

All these method are static method, in fact, they are the implementation of
virtual methods from the base class. Adding run-time type check is nice, but
very unlikely in this regard, since the method itself is found through the
virtual table of the type attach to the instance. hence cannot really be
confused. Specifically, I would avoid adding extra check in time sensitive
methods like _get_time() and get_internal_time(). The GOjbect typing system
uses many global lock which can quickly create contention.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.