[Bug 756611] playbin: Leak of playbin on errors from the source element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756611

--- Comment #3 from Vineeth <vineeth.tm at samsung.com> ---
posting async-done when subelements fails is not working.

I think the reason for this is, the element is still in ready state and not
changed to paused state.
So gstbin is just skipping the message being posted when the state is <= READY


regarding posting async-done for NO_PREROLL,
uridecodebin, playsink, decodebin2 already does that..
So probably even in playbin we should do that?


So if i understand it correctly
along with the change in the patch attached, should also check return value of
base class change and do async_start for ASYNC and async_done for NO_PREROLL??

something like this..
  ret = GST_ELEMENT_CLASS (parent_class)->change_state (element, transition);
  if (ret == GST_STATE_CHANGE_FAILURE)
    goto failure;
  else if (ret == GST_STATE_CHANGE_NO_PREROLL)
    do_async_done (decoder);
  else if (ret == GST_STATE_CHANGE_ASYNC)
    do_async_start (decoder);

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.