[Bug 756564] segment: Don't return -1 for out-of-segment values in running/stream-time conversion functions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Oct 16 08:04:50 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=756564

--- Comment #4 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Created attachment 313469
  --> https://bugzilla.gnome.org/attachment.cgi?id=313469&action=edit
First version of the _full variants patch for 1.8

Hi,

I'm halfway through the patch - basically it only needs addition of the _full
variant unit tests for stream time. But I did add all three remaining _full
variants and made the non-full ones use those, and nothing is breaking.

Please let me know if you have any comments so far, and meanwhile I'll add the
missing unit tests.

BTW, it looks very weird that we can return a negative
position/running_time/stream_time but not feed it into the opposite function.
OTOH we can't feed signed numbers into the functions without losing
accuracy/consistency and/or breaking the API - because we already have one
_full variant. A better solution is definitely needed for 2.0, but do you have
any ideas about now...?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list