[Bug 756563] pnmdec causes multifilesrc to return internal data flow error (caused by a gst_pad_push() error)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756563

Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313548|reviewed                    |none
             status|                            |
 Attachment #313548|0                           |1
        is obsolete|                            |

--- Comment #8 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> ---
Created attachment 313562
  --> https://bugzilla.gnome.org/attachment.cgi?id=313562&action=edit
completely reset parsing state at flush

(In reply to Sebastian Dröge (slomo) from comment #7)
> Review of attachment 313548 [details] [review]:
> [...]
> Or just memset() it all to 0 just to be sure and future-proof? Or add a
> reset() function that resets all these and is also called by start() :)

Hey Sebastian. Thanks for taking a look.

Are you referring to the s->mngr parser values? I'm not sure
resetting the entire codec state in 's' is correct here & it's
not needed to resolve this issue. New patch attached.

I have a couple of other minor changes for pnmdec after working
on it for a bit. I will include your reset() idea with them.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.