[Bug 756645] multiqueue: Improve incoming SEGMENT handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756645

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.6.1

--- Comment #3 from Edward Hervey <bilboed at bilboed.com> ---
Pushed to both master and 1.6

commit ebeee60c3f6e4cdaf54e3d5f5569cadc5019f0f3
Author: Edward Hervey <edward at centricular.com>
Date:   Thu Oct 15 16:32:42 2015 +0200

    multiqueue: Improve incoming SEGMENT handling

    Previously this code was just blindly setting the cached flow return
    of downstream to GST_FLOW_OK when we get a SEGMENT.

    The problem is that this can not be done blindly. If downstream was
    not linked, the corresponding sinqlequeue source pad thread might be
    waiting for the next ID to be woken up upon.

    By blindly setting the cached return value to GST_FLOW_OK, and if that
    stream was the only one that was NOT_LINKED, then the next time we
    check (from any other thread) to see if we need to wake up a source pad
    thread ... we won't even try, because none of the cached flow return
    are equal to GST_FLOW_NOT_LINKED.

    This would result in that thread never being woken up

    https://bugzilla.gnome.org/show_bug.cgi?id=756645

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.