[Bug 756810] New: segment_to_stream_time and position_from_stream_time miscalculate when applied_rate < 0

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756810

            Bug ID: 756810
           Summary: segment_to_stream_time and position_from_stream_time
                    miscalculate when applied_rate < 0
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: vivia at ahiru.eu
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Pasting from design docs:

===============================
Stream time is calculated using the buffer times and the preceding SEGMENT
event as follows:

    stream_time = (B.timestamp - S.start) * ABS (S.applied_rate) + S.time

For negative rates, B.timestamp will go backwards from S.stop to S.start,
making the stream time go backwards.
===============================

The way I understand it, the calculation for applied_rate < 0 should be:

    stream_time = (S.stop - B.timestamp) * ABS (S.applied_rate) + S.time

The existing code does not take into account S.stop at all, it just does
B.timestamp again.

Patch coming soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.