[Bug 749090] hlsdemux: set uri handler blocksize to reduce CPU usage

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749090

--- Comment #7 from A Ashley <bugzilla at ashley-family.net> ---
(In reply to Duncan Palmer from comment #5)
> Review of attachment 313443 [details] [review]:
> 
> This looks like it'll end up setting the blocksize property on the
> uridownloader when downloading metadata, as well as content. I don't think
> this'll be an issue for HLS, where playlists are smaller than a block anyway
> (whether it be 4 or 64K) - is it ok for the other adaptive demux elements?
> 

No, the gst_adaptive_demux_update_manifest_default() function uses
gst_uri_downloader_fetch_uri() to download the manifest. Therefore the change
to the gst_adaptive_demux_stream_download_uri() does not take part in manifest
requests.

> This change looks a bit cleaner if the CLAMP() macro is used in place of my
> original tests on blocksize higher and lower bounds.

Yes, CLAMP would be a bit cleaner.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.