[Bug 756564] segment: Don't return -1 for out-of-segment values in running/stream-time conversion functions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Oct 20 04:24:48 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=756564

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313469|0                           |1
        is obsolete|                            |

--- Comment #5 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Created attachment 313734
  --> https://bugzilla.gnome.org/attachment.cgi?id=313734&action=edit
_full variants and corresponding unit tests added

Attaching the patch with all three _full variants and their corresponding unit
tests. Fixes from https://bugzilla.gnome.org/show_bug.cgi?id=756810 have been
taken into account.

I am also committing some formula clarifications in the design docs. The code
ended up being almost impossible to follow without these clarifications, and
kind of difficult to follow even with these clarifications. In 2.0, the ability
to return a negative number here will *greatly, greatly, greatly* simplify the
code (get rid of all the res = -1 cases).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list