[Bug 750852] dashdemux: id at RepresentationType should be StringNoWhitespaceType but accepts spaces

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750852

--- Comment #14 from Florin Apostol <florin.apostol at oregan.net> ---
Review of attachment 313752:
 --> (https://bugzilla.gnome.org/review?bug=750852&attachment=313752)

please add some unit tests for this.

::: ext/dash/gstmpdparser.c
@@ +2910,3 @@
+      return FALSE;
+    if (*s == '%') {
+      /* returns FALSE for NUL, so safe for strings that end early */

I don't understand this comment. What does "end early" mean?

@@ +2911,3 @@
+    if (*s == '%') {
+      /* returns FALSE for NUL, so safe for strings that end early */
+      if (!g_ascii_isxdigit (s[1]) || !g_ascii_isxdigit (s[2]))

wouldn't s[1] and s[2] cause an out of bounds access if the string ends with
"%" ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.