[Bug 756628] audioclock: Add run time type check safety

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756628

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
It's not offensive at all, it's a legitimate question.

I agree with you that the first argument of any gst_audio_clock_*() function
should be a GstAudioClock * pointer.

I don't know why it's a GstClock * pointer here. Maybe for convenience because
the function gets assigned to some vfunc elsewhere that takes a GstClock.

We should check the rest of the GStreamer code to see how it's used. Perhaps we
should fix up the type of the first argument even. I think that'd be ok, it
would be both API and ABI compatible in all cases, the 'API breakage' that
would be is more of an inconvenience really, I don't think it would affect
anything in practice unless they compile with -Werror perhaps.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.