[Bug 756155] gst-plugins-bad-1.6.0 doesn't compile on OS X 10.6: kCGLPFAOpenGLProfile not available

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=756155

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313790|none                        |reviewed
             status|                            |

--- Comment #4 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 313790:
 --> (https://bugzilla.gnome.org/review?bug=756155&attachment=313790)

Looks mostly ok.

Just some suggestions for consistency with the rest of the codebase.

::: configure.ac
@@ +408,3 @@
+AS_OBJC_COMPILER_FLAG([-Wunused-command-line-argument],
+    [UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED=yes])
+AC_SUBST(UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED)

Make this an automake substitution instead of an autoconf one.

i.e AM_CONDITIONAL(UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED, test
"x$UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED" = "xyes")

::: gst-libs/gst/gl/gstglcolorconvert.c
@@ +988,3 @@
   gboolean in_tex_rectangular = FALSE;

+#if GST_GL_HAVE_OPENGL && defined(GL_TEXTURE_RECTANGLE)

I would prefer

#ifndef GL_TEXTURE_RECTANGLE
#define GL_TEXTURE_RECTANGLE 0x84F5
#endif

at the top of the file.

Assuming that 10.6 has texture rectangle support as GL_TEXTURE_RECTANGLE_ARB so
we can still get zerocopy with vtdec.

::: gst-libs/gst/gl/gstglcontext.c
@@ +582,3 @@
         goto next;

+#if GST_GL_HAVE_OPENGL && defined(GL_CONTEXT_PROFILE_MASK)

Again

#ifndef GL_CONTEXT_PROFILE_MASK
...

probably also needed for GL_CONTEXT_CORE_PROFILE_BIT and
GL_CONTEXT_COMPATIBILITY_PROFILE_BIT as well.

::: tests/examples/gl/cocoa/Makefile.am
@@ +5,3 @@
 cocoa_videooverlay_SOURCES = cocoa-videooverlay.m

+cocoa_videooverlay_OBJCFLAGS=$(if
@UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED@,-Wno-error=unused-command-line-argument)
\

It would probably make more sense to do (with the AM_CONDITIONAL in
configure.ac):

cocoa_videooverlay_OBJCFLAGS = ...
if UNUSED_COMMAND_LINE_ARGUMENT_FLAG_SUPPORTED
cocoa_videooverlay_OBJCFLAGS += -Wno-error=unused-command-line-argument
endif

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.